search

finos / openfin-react-hooks

A collection of React Hooks built on top of the Openfin API - from Scott Logic
Apache License 2.0
48 stars 19 forks source link

Fix for fin undefined on useInterApplicationBus hooks #38

Closed darrenfurr closed 4 years ago

darrenfurr commented 4 years ago

@ColinEberhardt - I added checks for fin on window to useInterApplicationBus hooks, so we can run outside of openfin for UI automation program.

finos-admin commented 4 years ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Darren Furr

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

ColinEberhardt commented 4 years ago

Hi @darrenfurr thank you for this fix, that's great - sorry it's taken so long to look at this PR. This project required that people who contribute code sign a Contribution Compliance Agreement, as described here:

https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Contribution+Compliance+Requirements#ContributionComplianceRequirements-ContributorLicenseAgreement

Is this something you'd be happy to sign so that we can accept your commit? Thanks.

darrenfurr commented 4 years ago

@ColinEberhardt - Checking with my employer. I don't think it will be a problem. I'll let you know.

maoo commented 4 years ago

@finos-cla-bot[bot] check

finos-admin commented 4 years ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Darren Furr

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

finos-admin commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

finos-admin commented 4 years ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Darren Furr

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

maoo commented 4 years ago

@finos-cla-bot[bot] check

finos-admin commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

maoo commented 4 years ago

@darrenfurr , we got a green light! Thanks for your first contribution! FYI @ColinEberhardt

ColinEberhardt commented 4 years ago

Nice one - thanks @darrenfurr - much appreciated!