search

finos / openfin-react-hooks

A collection of React Hooks built on top of the Openfin API - from Scott Logic
Apache License 2.0
48 stars 18 forks source link

add hooks to invoke callbacks when child windows closed #45

Closed jlight-scottlogic closed 4 years ago

jlight-scottlogic commented 4 years ago

Resolves #7 Resolves #8

Rather than hardcoding the "close parent window" functionality into the hook, I allowed a callback to be passed so that different behaviour can be invoked as a result of either one/all of the child windows being closed.

jlight-scottlogic commented 4 years ago

The version in the package.json and package-lock.json should be bumped to 1.4.0. Apart from that, it looks good :)

I wasn't sure whether we should just do one major version bump after all of these changes go in. If your work is changing any signatures of any methods in the existing API, that is. Happy to add a minor version bump either way.