search

finos / openfin-react-hooks

A collection of React Hooks built on top of the Openfin API - from Scott Logic
Apache License 2.0
48 stars 18 forks source link

useNotification doesn't work with OpenFin versions 13.X.X.X or 14.X.X.X #56

Open ms14981 opened 4 years ago

ms14981 commented 4 years ago

The cause seems to be that getWebWindow method on the OpenFin API Window sometimes returns undefined.

To test in the demo app, launch it with openfin -v 14.78.47.23 --launch --config ./public/app.dev.json instead of npm run launch. Go to useNotification then click launch.

Links:

Todo: Find a workaround (might be able to use the old v1 methods in fin.desktop in v2 of the OpenFin JS API).

ms14981 commented 4 years ago

This MCVE should demonstrate the issue with getWebWindow: https://github.com/ms14981/reproduce-openfin-getWebWindow-bug

ms14981 commented 4 years ago

Latest response from OpenFin:

A fix for this has been merged into canary (15.80.50.21). Will let you know when a stable build is released with this fix.

ms14981 commented 4 years ago

Response from OpenFin on June 1st:

This should be fixed on the last two stable versions 15.80.50.34 and 16.83.50.9