finos / perspective

A data visualization and analytics component, especially well-suited for large and/or streaming datasets.
https://perspective.finos.org/
Apache License 2.0
7.72k stars 1.05k forks source link

Add directory in repository definition for all (generated) package.json files #2022

Open tsteenbe opened 1 year ago

tsteenbe commented 1 year ago

Adding directory will enable perspective users to use to license/security compliance tool such ORT to verify included FOSS licenses, generated SBOMs and create a source code bundle.

packages/perspective-cli/package.json#L18-L21

    "repository": {
        "type": "git",
        "url": "https://github.com/finos/perspective"
    },

NPN package-json#repository says "If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives"

    "repository": {
        "type": "git",
        "url": "https://github.com/finos/perspective"
        "directory": "packages/perspective-cli"
    },

Similarly rust/perspective-viewer/package.json should be

    "repository": {
        "type": "git",
        "url": "https://github.com/finos/perspective"
        "directory": "rust/perspective-viewer"
    },
tsteenbe commented 1 year ago

Normally I would submit a PR to fix up the package.json but it seems several of these are generated, not sure by what.