search

finos / perspective

A data visualization and analytics component, especially well-suited for large and/or streaming datasets.
https://perspective.finos.org/
Apache License 2.0
8.38k stars 1.17k forks source link

Convert `@finos/perspective-viewer-d3fc` to TypeScript #2432

Closed brochington closed 9 months ago

brochington commented 10 months ago

This PR is as a foundational first step to adding types to the perspective-viewer-d3fc package. Adding full typing to perspective-viewer-d3fc is a very large and complex task, and the resulting PR would be...massive. The aim of this PR is offer a starting ground for adding better types in the future.

In this PR:

Very minimal changes to the original functional code have been made, and no change in behavior should be noticeable.

texodus commented 10 months ago

Thanks for the PR!

Draft PRs are for work that is under development but not ready to be merged. Why is this PR in draft? Are you planning on finishing this work or ...?

Adding full typing to perspective-viewer-d3fc is a very large and complex task, and the resulting PR would be...massive.

Hence why it has not been done yet, I'm not interested in a perpetually half-typed package.