search

finos / perspective

A data visualization and analytics component, especially well-suited for large and/or streaming datasets.
https://perspective.finos.org/
Apache License 2.0
7.94k stars 1.06k forks source link

Refactor How Column Style Components Are Selected #2443

Closed ada-x64 closed 6 months ago

ada-x64 commented 7 months ago

This PR does what it says on the tin. The goal is to prevent unnecessary style component renders and to replace the default "no styles available" content with a hard error.

There are some remaining issues with the symbol column settings when aggregating. In particular, the column value selector does not get the aggregated values, but the raw table values, so the key-value selector doesn't match up with what is in the plugin.

ada-x64 commented 7 months ago

This has been updated to add a stub, remove expect_throws, and add a fixture test. In order to add the fixture test, I rebased this on https://github.com/finos/perspective/pull/2447