search

finos / perspective

A data visualization and analytics component, especially well-suited for large and/or streaming datasets.
https://perspective.finos.org/
Apache License 2.0
8.38k stars 1.17k forks source link

Context Menu copy/export throw error #2446

Closed sinistersnare closed 10 months ago

sinistersnare commented 10 months ago

Bug Report

Since #2428, the two custom elements perspective-export-menu and perspective-copy-menu are not properly exported into JavaScript. They are no longer customElements.defined, among other needed pieces to externalize them. The export and copy boxes inside of a perspective-viewer still function properly.

Steps to Reproduce:

  1. Go onto an example that uses a workspace
  2. Click on the 'export' or 'copy' labels in the workspace context menu
  3. Errors in console.

Expected Result:

The export or copy menus

Actual Result:

copy_export_error.webm

Additional Context:

Some code was deleted in the #2428 PR that caused this.