finos / perspective

A data visualization and analytics component, especially well-suited for large and/or streaming datasets.
https://perspective.finos.org/
Apache License 2.0
7.95k stars 1.06k forks source link

Remove Any Old Expressions from Codebase #2447

Closed ada-x64 closed 6 months ago

ada-x64 commented 7 months ago

This PR looks huge but it's actually quite small!

It does two things:

  1. Datagrid was using an old-style expression when populating the view. This has been fixed.
  2. I added a fixture to the playwright tests to ensure that no old-style expressions are still around.

Main changes occur in:

The rest are dependency updates to use the fixture.

ada-x64 commented 7 months ago

I've updated this PR to add a timeout configuration to the fixture. Now any function that can take a timeout option will wait for at most 5 seconds. This should save us substantial time on waitFor and other locator functions.