Expression Editor Tweaks

finos / perspective

A data visualization and analytics component, especially well-suited for large and/or streaming datasets.

https://perspective.finos.org/

Apache License 2.0

7.73k stars 1.05k forks source link

Closed ada-x64 closed 6 months ago

ada-x64 commented 7 months ago

Based on #2437.

Sidebar trapdoor sizing now stays sticky on any parameter change instead of just sticking on column name change.
Expression editor has more breathing room for errors.
Expression editor styling now takes the size of the unavailable buttons into account by using visibility: none.
Update tests to use new playwright functionality in order to fix bugs.
Added a test to ensure the trapdoor sizing remains at max width.

Before (In #2437): Screenshot 2023-12-01 at 2 54 33 PM

After (this PR): Screenshot 2023-12-01 at 2 52 57 PM Screenshot 2023-12-01 at 2 51 56 PM

ada-x64 commented 6 months ago

Closing in favor of #2459