Improve C++/LSP/VSCode Integration - Githubissues

finos / perspective

A data visualization and analytics component, especially well-suited for large and/or streaming datasets.

https://perspective.finos.org/

Apache License 2.0

7.73k stars 1.05k forks source link

Improve C++/LSP/VSCode Integration #2467

Closed timbess closed 4 months ago

timbess commented 7 months ago

Improvements to C++ developer experience:

Setup ClangD with Emscripten/Python.

Fixes:

Fix boost include shadowing local headers.

Before this I was having a hard time getting Intellisense in VSCode to work properly particularly in emscripten.cpp with the calls to code in ./.emsdk in the workspace root. After these changes it works great for me:

Also if you build the Python library and open python/perspective in VSCode, pybind and everything works as well:

tomjakubowski commented 6 months ago

This works great! Just as a note, when I tried it out, having clangd enabled + configured led to Microsoft's "C/C++" extension outputting a bunch of bogus errors (it looked like it was trying to parse a C++ source file as C). So I disabled that extension in this workspace, just having the clangd extension enabled seems to be fine.

finos-cla-bot[bot] commented 4 months ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

finos-cla-bot[bot] commented 4 months ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

finos-cla-bot[bot] commented 4 months ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

finos-cla-bot[bot] commented 4 months ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

finos-cla-bot[bot] commented 4 months ago

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@timbess).

The repository you are attempting to contribute to uses a CLA Bot to check pull requests; in order to be added to the CLA Bot you must follow these instructions.

Thank you once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

texodus commented 4 months ago

Closing in favor of #2541