search

finos / software-project-blueprint

Project blueprint for Fintech Open Source Foundation hosted projects.
https://odp.finos.org
Apache License 2.0
28 stars 23 forks source link

Update Docusaurus GitHub Action #24

Closed mcleo-d closed 3 years ago

mcleo-d commented 3 years ago

Description

This pull request updates the Software Project Blueprint docusaurus.yml with the relative jobs from the Open Developer Platform docusaurus.yml below.

https://github.com/finos/open-developer-platform/blob/master/.github/workflows/docusaurus.yml

Included Jobs

The jobs includes in the GitHub Action are ...

Excluded Jobs

name: Build Contributing page was excluded from the action.

mcleo-d commented 3 years ago

@maoo - PR merged to move forward with #23 dependency.

maoo commented 3 years ago

@maoo - PR merged to move forward with #23 dependency.

I haven't tested this, and the action has quite some side effects and corner cases, so I don't know if this PR will work.

On one hand, I'd suggest to revert it; on the other, I think we should deprecate this action and move to netlify.com , which is what we already use for ODP, and what I suggest we use for all our website moving forward.

mcleo-d commented 3 years ago

Hi @maoo - I'm more than happy to take your recommendation on this PR. This script allows #23 to succeed, but netlify.com might give more control for integration and testing.

Maybe we can discuss as #23 gets closer to being merged?

James 🚀