finos / spring-bot

Spring Boot + Java Integration for Symphony/Teams Chat Platform Bots and Apps
https://springbot.finos.org
Apache License 2.0
60 stars 35 forks source link

Multiple KoreAI Issues #122

Closed robmoffat closed 3 years ago

robmoffat commented 3 years ago

Bug Report

  1. Why do I have to configure a regular symphony.bot endpoint? Why does it need this as well as all the koreAI instances?
  2. KoreAIEventHandler.afterPropertiesSet() is never called.
  3. Better error messages are needed for configuration issues - it's impossible to say which bot is broken in a multi-bot setup.\
  4. If the user types /hi, that whole thing is sent to Kore. Really it should remove the initial /.
robmoffat commented 3 years ago

Fixed 2. Fixed 3. Fixed 4.

  1. This was due to non-optional bean definition in symphony-api-spring-boot-starter. Should be fixed now.