ChatButton action is visible in all rooms even if restricted with "rooms" attribute of @ChatButton

[pankaj-a-khandelwal-db]

Bug Report

Steps to Reproduce:

1. This is from Expense Workflow example from Spring Bot - Getting Started page
2. Annotate controller method to map ChatButton action

   @ChatButton(value = OpenedClaim.class, buttonText = "Approve", rooms = {"Claim Approval Room PK"})
   public List<Response> approveClaim(User approver, Addressable fromStream, OpenedClaim claim) {

   3. As part of some previous action in workflow return WorkResponse containing @Work OpenedClaim form to different Rooms/Users
   4. Observe rooms where you sent above response including "Claim Approval Room PK" and even individual user chat

Expected Result:

• ChatButton action is limited to room(s) mentioned in rooms attribute of @ChatButton
• If rooms attribute is skipped then action should be visible in all rooms

Actual Result:

• Approve ChatButton action from above example is not restricted to rooms mentioned in rooms attribute of @ChatButton
• Approve action is also visible in individual user chat (see screenshots below)
• Further, on click of Approve button, action is invoked if initiator is a User. However, ignored when its from SymphonyRoom (secondary issue as primary one exists)
• Secondary issue can be addressed in ChatButtonChatHandlerMapping.createMappingRegistration -> canBePerformedHere() by adding below check Or fixing just primary issue -

  if((a.getAddressable() instanceof User) && (cb.rooms().length > 0)) {
  return false;
  }

Environment:

Version 8.0.1+

Additional Context:

As seen in expected Claims Approval room

As seen in other rooms

As seen in User chat