search

finos / spring-bot

Spring Boot + Java Integration for Symphony/Teams Chat Platform Bots and Apps
https://springbot.finos.org
Apache License 2.0
60 stars 35 forks source link

Contribution/fix acm finding #279

Closed sureshrupnar closed 2 years ago

robmoffat commented 2 years ago

Don’t merge this with a failing build please

sureshrupnar commented 2 years ago

Don’t merge this with a failing build please

Yes Rob, actually we created Environment variables in Github. This is not present in contribution branch. Branch will automatically sync and build will get success. Waiting for Sync to get latest code in Contribution branch.

robmoffat commented 2 years ago

Hi Suresh,

The build should still pass in Github even on the branch. The branch shouldn't be running tests that won't work.

If you rename the tests to 'IT' then they will only be run on the master branch. This is probably what you need to do.

vaibhav-db commented 2 years ago

What's happened to JsonIdentity1ConfigTest and JsonIdentity2ConfigTest

We already covered functionality test cases for Identity classes. As we don't want to keep private and certificate on json file. we have remove these test cases and json files.

robmoffat commented 2 years ago

you need to merge this to symphony-java-toolkit-master now