search

finos / spring-bot

Spring Boot + Java Integration for Symphony/Teams Chat Platform Bots and Apps
https://springbot.finos.org
Apache License 2.0
60 stars 35 forks source link

Override MimePull lib version #355

Closed pankaj-a-khandelwal-db closed 2 years ago

pankaj-a-khandelwal-db commented 2 years ago

SpringBoot 2.7.0 pulls 1.10 version of below lib which is compiled with Java11 and hence causes errors when running on Java8

robmoffat commented 2 years ago

What's mime pull used for? Is the version you're proposing compatible with Spring Boot 2.7?

pankaj-a-khandelwal-db commented 2 years ago

Jersey-media-multipart has dependency on mimepull lib. However, newer version of dependency is forced via SpringBoot 2.7.0 BOM. See this link for issue details - https://github.com/spring-projects/spring-boot/issues/31133

This explain why they added it in 1st place - https://github.com/spring-projects/spring-boot/issues/14924 And this say that it is redundant and might not be needed as part of SpringBoot BOM - https://github.com/spring-projects/spring-boot/pull/31145

Instead of removing dependency altogether, its safe to downgrade it to latest version compiled with Java8. Ran Bot post changes on both Symphony and MS Teams and they ran fine.