search

finos / spring-bot

Spring Boot + Java Integration for Symphony/Teams Chat Platform Bots and Apps
https://springbot.finos.org
Apache License 2.0
60 stars 35 forks source link

File Storage not working properly #386

Closed abhishekdahiya-db closed 1 year ago

abhishekdahiya-db commented 1 year ago

File Storage not working properly. if we send multiple work objects and try to retry one of the work object we always get the latest work object not the work object we are trying for.

robmoffat commented 1 year ago

Addressed by

vaibhav-db commented 1 year ago

Hi Rob,

This bug is for file state storage. We have find when multiple room object inserted in file. It is not pulling the latest required object. We have fixed this issue.

robmoffat commented 1 year ago

HI sorry I assigned the wrong Abhishek! Did I link the wrong issue here? Do we have a test that demonstrates this?

vaibhav-db commented 1 year ago

Yes we have same test FileStateStorageTest. No changes in test.

robmoffat commented 1 year ago

But the old test was working right? If so, then there must be behaviour of the class that was not exercised by the test. Can we extend the test so that it covers the missing behaviour?