finos / symphony-bdk-java

The Symphony BDK (Bot Developer Kit) for Java helps you to create production-grade Chat Bots and Extension Applications on top of the Symphony REST APIs.
https://symphony-bdk-java.finos.org
Apache License 2.0
23 stars 69 forks source link

Make core starter objects accessible in the app starter #512

Open symphony-elias opened 3 years ago

symphony-elias commented 3 years ago

Feature Request

Description of Problem:

When creating an extension app project (maven or gradle) depending solely on symphony-bdk-app-spring-boot-starter, one cannot access beans declared in symphony-bdk-core-spring-boot-starter like @Slash. Reason is: symphony-bdk-app-spring-boot-starter depends on symphony-bdk-core-spring-boot-starter as a runtime dependency

Potential Solutions:

Make symphony-bdk-app-spring-boot-starter depends on symphony-bdk-core-spring-boot-starter as a compile dependency

ystxn commented 3 years ago

Are other third-party transitive dependencies being considered in this enhancement or just the bdk app spring starter to bdk core spring starter?

Some notable ones include:

symphony-youri commented 3 years ago

Usually relying on Maven transitive dependencies is not considered a good practice :) But I agree it makes sense for starter like modules to ease developer experience