finos / symphony-bdk-java

The Symphony BDK (Bot Developer Kit) for Java helps you to create production-grade Chat Bots and Extension Applications on top of the Symphony REST APIs.
https://symphony-bdk-java.finos.org
Apache License 2.0
23 stars 68 forks source link

Ignore Ceservice in Health Check #742

Closed ystxn closed 1 year ago

ystxn commented 1 year ago

Bug Report

Start new Spring Core or App Starter project

Expected Result:

Bot/app starts up with successful health check

Actual Result:

Exception thrown:

2023-02-06 14:12:42.863 DEBUG 10821  --- [on(2)-127.0.0.1] c.s.b.a.s.s.SymphonyBdkHealthIndicator   : Health check failed.

com.symphony.bdk.http.api.ApiRuntimeException: com.symphony.bdk.http.api.ApiException: {"services":{"pod":{"status":"UP","version":"20.15.2"},"key_manager":{"status":"UP","version":"20.15.2"},"datafeed":{"status":"UP","version":"2.8.29"}},"status":"DOWN","users":{"agentservice":{"authType":"RSA","status":"UP"},"ceservice":{"message":"Ceservice authentication credentials missing or misconfigured","status":"DOWN"}},"version":"22.12.2-658"}
    at com.symphony.bdk.core.service.health.HealthService.execute(HealthService.java:100) ~[symphony-bdk-core-2.12.0.jar:2.12.0]
    at com.symphony.bdk.core.service.health.HealthService.healthCheckExtended(HealthService.java:69) ~[symphony-bdk-core-2.12.0.jar:2.12.0]
    at com.symphony.bdk.app.spring.service.SymphonyBdkHealthIndicator.doHealthCheck(SymphonyBdkHealthIndicator.java:47) ~[symphony-bdk-app-spring-boot-starter-2.12.0.jar:2.12.0]
    at org.springframework.boot.actuate.health.AbstractHealthIndicator.health(AbstractHealthIndicator.java:82) ~[spring-boot-actuator-2.7.8.jar:2.7.8]

Environment:

Additional Context:

CE is an optional pod component and the Ceservice auth credentials are sometimes not configured in the agent - this should not impact regular operations of a given bot or app so the health check should ignore this specific scennario