Using latest openapi generator + generating profile-manager api - Githubissues

finos / symphony-bdk-python

Symphony Python Bot Development Kit (BDK)

https://symphony-bdk-python.finos.org/

Apache License 2.0

31 stars 34 forks source link

Using latest openapi generator + generating profile-manager api #265

Closed symphony-elias closed 2 years ago

symphony-elias commented 2 years ago

Ticket

PLAT-11835

Description

In this implementation we:

upgraded the openapi-generator version to use 5.4.0. Custom branch used for the jar generation can be found here.
custom templates that were part of the templates module were integrated in the custom jar, hence removed from this project
all existing APIs and models were regenerated using the new openapi-generator version
as prerequisite for the group extension (coming soon), Group APIs were generated

Checklist

[x] Referenced a ticket in the PR title and in the corresponding section
[x] Filled properly the description and dependencies, if any
[x] Unit tests updated or added
[x] Docstrings added or updated
[x] Updated the documentation in docs folder

symphony-youri commented 2 years ago

Why isn't https://github.com/OpenAPITools/openapi-generator/pull/11758 something that could be merged?

We could use a better description of the changes, it seems a lot was done here (changing the templates, the generator, adding a new swagger spec)

Would there be an interest in splitting the groups separated (an entire separated folder tree with its own generated code folder), so that if we decide to split it we just have to move the entire folder away? (it seems a bit YAGNI though) Or maybe because the update cycle of the group spec vs the pod/agent spec will be different? we will update one or not the other (but that we can deal with with fixed commit ids)