finos / symphony-bdk-python

Symphony Python Bot Development Kit (BDK)
https://symphony-bdk-python.finos.org/
Apache License 2.0
31 stars 34 forks source link

Not use bot username when Datafeed tag is not set #320

Closed symphony-soufiane closed 1 year ago

symphony-soufiane commented 1 year ago

Description

The datafeed tag is an internal feature and the tag property is optional in the configuration. So far, when no tag is configured, the bot username was used as a tag. This leads to production issues when the tag is an old hanging one. In this PR, we only set the tag in datafeed calls when it is provided in configuration, otherwise a null value is put. For the same occasion, I corrected the datafeed documentation with some links returning a 404 page error. The tag property is not documented as it is only internal feature.