finos / symphony-wdk

Symphony Workflow Developer Kit (WDK), a bot capable of running workflows
Apache License 2.0
3 stars 10 forks source link

Workflow cannot be deployed when a join activity after a condition form reply #163

Closed yinan-symphony closed 2 years ago

yinan-symphony commented 2 years ago

Bug Report

given a workflow having a join activity after a conditional form reply as

id: condition-form-reply-join
activities:
  - send-message:
      id: sendForm
      on:
        message-received:
          content: /go
      content: |
        <messageML>
          <form id="sendForm">
            <text-field name="ticker" placeholder="Please enter the Stock Ticker here"></text-field>
            <textarea name="content" placeholder="Please enter your Research Content here and then Submit form."></textarea>
            <button name="send-answers" type="action">Send</button>
          </form>
        </messageML>
  - send-message:
      id: response0
      on:
        form-replied:
          form-id: sendForm
      if: ${sendForm.ticker == 'GOOG'}
      content: |
        <messageML>
          First reply (if): ${sendForm.content}
        </messageML>
  - send-message:
      id: response1
      on:
        form-replied:
          form-id: sendForm
      else: {}
      content: |
        <messageML>
          First reply (else): ${sendForm.content}
        </messageML>
  - send-message:
      id: response2
      on:
        one-of:
          - activity-completed:
              activity-id: response0
          - activity-completed:
              activity-id: response1
      content: |
        <messageML>
          END
        </messageML>

Expected Result:

the workflow is deployed successfully and running as correctly according to the right conditions

Actual Result:

the workflow is not able to deploy

Environment:

...version and build of the project, OS and runtime versions, virtualised environment (if any), etc. ...

Additional Context:

...add any other context about the problem here. If applicable, add screenshots to help explain...

symphony-soufiane commented 2 years ago

Fixed and will be released in WDK 1.3.0

163