Reference Data Service Migrated from Node/NestJs to Java/SpringBoot

linux-foundation-easycla[bot] commented 4 months ago

:x: - login: @utsavk28 / name: Utsav Khatu . The commit (ecba110ec44206a66014519936ad6e7e62ef38e7, 6d1ebb5a3f38b7cdf05b4afe4dd8df919931d40c) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

netlify[bot] commented 4 months ago

Deploy Preview for lucky-concha-f3599f failed. Why did it fail? →

Name	Link
Latest commit	ecba110ec44206a66014519936ad6e7e62ef38e7
Latest deploy log	https://app.netlify.com/sites/lucky-concha-f3599f/deploys/667566deac0a4c0008e45402

DovOps commented 2 months ago

@utsavk28 Thanks for your contribution. One of the design goals of the TraderX project is to be a polyglot, showing multiple different language/ implementations for the various services being used. This helps ensure that developers of all types can find some aspect of this project to relate to, and it also helps it resemble the combinations of technologies that are often found distributed apps in in large companies in the industry. As such, I believe we should be keeping at least one of the HTTP services in JavaScript/Node, as we have sufficient coverage of Java/Spring with the Accounts, Position and Trade Services and the Trade Processor. While it's nice to see this re-implemented in spring, merging into the Main branch would defeat the purpose of the intial design/entry level.

One suggestion where you could contribute this change would be to create a version of the project which is 100% java (namely, the trade feed, ref-data service, and people service). If you want to do this I recommend creating a fork/branch which also shares the data transfer objects, and benefits from a gradle multi-module build with internal dependencies.

What do you think? I encourage you to join the project call to discuss further. Thanks again!

utsavk28 commented 2 months ago

Hi @DovOps! Seems like an interesting idea, would definitelgy like to pitch in. How do i join the project calls ? PS: the above changes were for some event we're trying to go with (just fyi)

finos / traderX