search

finos / traderX

https://demo.traderx.finos.org/
Apache License 2.0
54 stars 60 forks source link

initial conversion of main services - build and deploy #206

Closed matthewgardner closed 2 months ago

matthewgardner commented 2 months ago

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS Corporate Contributor License Agreement.

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

https://github.com/finos/traderX/issues/203

Complete

linux-foundation-easycla[bot] commented 2 months ago

CLA Missing ID CLA Not Signed

netlify[bot] commented 2 months ago

Deploy Preview for lucky-concha-f3599f canceled.

Name Link
Latest commit 341a1b308c185b66334b5d02942bc80ea84f097f
Latest deploy log https://app.netlify.com/sites/lucky-concha-f3599f/deploys/66e1e91c296cb1000853d177
DovOps commented 2 months ago

@matthewgardner once we sort out the CLA situation, we're ready to merge this. I think you can do this by clicking the red CLA button above.

bingenito commented 2 months ago

/easycla

bingenito commented 2 months ago

/easycla

matthewgardner commented 2 months ago

Testing evidence below:

Screenshot 2024-09-10 at 21 02 29

Suggestions for future pr (out of scope of this PR?) is to enable health endpoints on service so make it easy to spot when services are actually ready.

DovOps commented 2 months ago

Suggestions for future pr (out of scope of this PR?) is to enable health endpoints on service so make it easy to spot when services are actually ready.

Definitely. See issue #124

DovOps commented 2 months ago

/easycla

DovOps commented 2 months ago

@bingenito @maoo @karlmoll - Need a bit of help sorting out the easyCLA issue, as it has to do with a commit from me that is not using the right e-mail. Tried fixing this but it did not work. Once done we can merge this, unless we should merge and note the exception.

maoo commented 2 months ago

@bingenito @maoo @karlmoll - Need a bit of help sorting out the easyCLA issue, as it has to do with a commit from me that is not using the right e-mail. Tried fixing this but it did not work. Once done we can merge this, unless we should merge and note the exception.

@DovOps , could you please confirm that the email address that you see on https://api.github.com/repos/finos/traderX/commits/cd9ffec6febfe75913dcf95e26e0b1682e75c79f is also on https://github.com/settings/emails ?

In parallel, I'd also check git config --list | grep email to make sure which email you use to sign commits; another - maybe longer - option is to update the user.email config, git reset and then commit again on @matthewgardner branch.

DovOps commented 2 months ago

@maoo it's the noreply one for me, which apparently was in my settings on the local repo for some reason. I'll try a git reset + commit if that works

DovOps commented 2 months ago

This did not succeed. Merging this as-is. @bingenito can confirm that @DovOps (author of https://github.com/finos/traderX/commit/cd9ffec6febfe75913dcf95e26e0b1682e75c79f ) has agreed to CLA.

bingenito commented 2 months ago

This did not succeed. Merging this as-is. @bingenito can confirm that @DovOps (author of cd9ffec ) has agreed to CLA.

As CLA Manager for Morgan Stanley I confirm that @DovOps is covered under our EasyCLA