search

finos / voice-metadata-standard

This is a project from FINOS Voice program to define a standard for call metadata.
Apache License 2.0
25 stars 9 forks source link

participant definition proposal #49

Closed pinczo closed 4 years ago

pinczo commented 4 years ago

participant definition changes:

  1. new "member" definition inside participant for {name, firmName, groupId, groupName, timeZoneOffset}

  2. "farEndName" field removed (use participant > member > name) - if we list all the participants in "participants" we can get farEndName from there

  3. new "involvement" field - "enum":["source", "destination", "participant"] - proposal is to use it instead of "source" and "destination" fields on root level

  4. "states" definition lists all the participant states with timestamp and duration

kemmiso commented 4 years ago

Vitor - I am clearly happy with these but as I am maybe more involved in the specific changes it is probably best if you review and approve / comment?

vitorespindola commented 4 years ago

@pinczo After the merge of PR #44 into master your PR is now conflicting.

I'd like to suggest to separate it into distinct PRs, one for the member definition change and another for call states, since they are non-related changes.

So my suggestion is to create these two PRs:

1 - Something like "Move participant user information to it's own definition" that will contain the member change commit.

2 - Something like "Store call states overtime", with the state changes.

I'll approve (1) immediately, but I'll like to propose some changes in (2).

I can assist you in this if you want. Just let me know.