finos / vuu

Vuu - an open source view server and html 5 based UI system
https://vuu.finos.org
Apache License 2.0
44 stars 27 forks source link

new action type for Menu RPC responses #1443

Open heswell opened 3 months ago

heswell commented 3 months ago

Vuu defines a ViewPortAction class. There are three subclasses of VuuPortAction that the UI currently handles

where notificationType may be "error", "success", "warning" or "info" message is the message to display to the user e.g "Trade xyz has been cancelled" title optional, client will default it to simply "Success", "Error" etc if not provided

What I find slightly confusing about the existing declarations is that messages like ViewPortRpcFailure also extend ViewPortAction

I see the action as an optional part of the payload on either an RPC success response or an RPC error response (where NO_ACTION is assumed as the implicit action if none provided)

This will allow us to display a notification to a user, indicating the success or otherwise of a serverside action initiated by the user. We can do this with generic code on the ui, driven by the server.

naleeha commented 2 months ago

Might be best to wait for new RPC message type defined as outcome as https://github.com/finos/vuu/discussions/1447 Being tackled as part of this change https://github.com/finos/vuu/issues/1434