search

finsweet / developer-starter

Developer starter template for Finsweet projects.
https://www.finsweet.com/
187 stars 67 forks source link

An extra step to make Github Actions works #31

Closed initweb-fr closed 1 year ago

initweb-fr commented 1 year ago

I noticed a “new step” to start with DS and it seems that you haven’t talk about it anywhere. So I thought it might interest you.

When I clone your DS Template on my GitHub, I add the NPM token in Actions. Easy. If we only do this, we will have an error when pushing to NPM. GitHub Actions is not permitted to create or approve pull requests. Capture d’écran 2023-03-02 à 16 26 18

In order to make it work, we need to go to Repo Settings/Actions/General/Workflow Permissions and check “Read and write permissions” and “Allow Github Actions to create and approve pull requests”

Before (by default): Capture d’écran 2023-03-02 à 16 25 55

After: Capture d’écran 2023-03-02 à 16 25 50

Then the Action work perfectly ! Capture d’écran 2023-03-02 à 16 27 02

There is no documentation about this extra step so I thought it was useful to submit a new issue. That's it !

Trully love your work ! Have a great day !

alexiglesias93 commented 1 year ago

Great suggestion, addressed in #34 , thank you!