search

fintech-systems / virtualmin-api

A Virtualmin API designed to run standalone or as part of a Laravel Application
MIT License
6 stars 1 forks source link

[FIX] foreach loop when getting domains and there is no data #23

Closed Domeshow closed 2 years ago

Domeshow commented 2 years ago

Let's take the case where the user tries to connect with false identifiers, then he will want to retrieve the list of domains to be sure that he is connected. except that $output will be null because its identifiers are wrong. what will bug the foreach loop

codecov-commenter commented 2 years ago

Codecov Report

Merging #23 (328b4f7) into main (8a6da78) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              main     #23   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
- Complexity      30      31    +1     
=======================================
  Files            3       3           
  Lines           81      82    +1     
=======================================
- Misses          81      82    +1
Impacted Files Coverage Δ
src/VirtualminApi.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a6da78...328b4f7. Read the comment docs.

marclaporte commented 2 years ago

@eugenevdm FYI, @Domeshow works with @fabiomontefuscolo and I on the same project.

Thanks!