search

fintraffic-design / fds-coreui-components

Fintraffic Design System's Core UI Components. Work heavily in progress.
European Union Public License 1.2
0 stars 0 forks source link

fds-dialog: Prevent updating dialog when modal has not changed #38

Closed rooperl closed 1 year ago

rooperl commented 1 year ago

Since fds-dialog has more than one property now (see https://github.com/fintraffic-design/coreui-components/pull/37), a check needs to be added to the updated method to only close and show the dialog again if the modal property changes.

ninopenttinen commented 1 year ago

Weird error on the CI check, obviously looks unrelated to this change, but you could take a look if you have time anyway.

rooperl commented 1 year ago

Weird error on the CI check, obviously looks unrelated to this change, but you could take a look if you have time anyway.

Re-running the job seemed to solve the issue.