search

fiorix / go-diameter

Diameter stack and Base Protocol (RFC 6733) for the Go programming language
Other
252 stars 143 forks source link

Fixed wrong type for VisitedPLMNID #167

Closed uri200 closed 2 years ago

uri200 commented 2 years ago

Signed-off-by: Oriol Batalla obatalla@fb.com

VisitedPLMNID is set as Unsigned type but it is type OctetString.

We found out this because our HSS implementation was always returning VisitedPLMNID as 0.

test passed


╰─ make run_docker_test
ok      github.com/fiorix/go-diameter/v4/diam   (cached)
?       github.com/fiorix/go-diameter/v4/diam/avp   [no test files]
ok      github.com/fiorix/go-diameter/v4/diam/datatype  (cached)
ok      github.com/fiorix/go-diameter/v4/diam/diamtest  (cached)
ok      github.com/fiorix/go-diameter/v4/diam/dict  (cached)
ok      github.com/fiorix/go-diameter/v4/diam/sm    (cached)
ok      github.com/fiorix/go-diameter/v4/diam/sm/smparser   (cached)
ok      github.com/fiorix/go-diameter/v4/diam/sm/smpeer (cached)
?       github.com/fiorix/go-diameter/v4/examples/bare  [no test files]
?       github.com/fiorix/go-diameter/v4/examples/client    [no test files]
?       github.com/fiorix/go-diameter/v4/examples/client/diameter_sy    [no test files]
?       github.com/fiorix/go-diameter/v4/examples/diam_sctp_client  [no test files]
?       github.com/fiorix/go-diameter/v4/examples/grouped   [no test files]
?       github.com/fiorix/go-diameter/v4/examples/s6a_client    [no test files]
?       github.com/fiorix/go-diameter/v4/examples/s6a_proxy/protos  [no test files]
?       github.com/fiorix/go-diameter/v4/examples/s6a_proxy/service [no test files]
ok      github.com/fiorix/go-diameter/v4/examples/s6a_proxy/service/test    (cached)
?       github.com/fiorix/go-diameter/v4/examples/s6a_server    [no test files]
?       github.com/fiorix/go-diameter/v4/examples/server    [no test files]
?       github.com/fiorix/go-diameter/v4/examples/snoop [no test files]
?       github.com/fiorix/go-diameter/v4/examples/wireshark-dict-tool   [no test files]
emakeev commented 2 years ago

LGTM. Thanks.