search

fiorix / go-smpp

SMPP 3.4 Protocol for the Go programming language
MIT License
220 stars 134 forks source link

TLVBody.SerializeTo doesn't write to io.writer #12

Closed haisum closed 8 years ago

haisum commented 8 years ago

Line 30 on pdufield/tlvbody.go, SerializeTo function doesn't write anything to io.Writer.

haisum commented 8 years ago

Pull request: https://github.com/fiorix/go-smpp/pull/13

fiorix commented 8 years ago

Not surprised, I never really tested TLV. There's probably TODOs in the code, which is mostly inherited from Kevin's lib.