search

fiorix / go-smpp

SMPP 3.4 Protocol for the Go programming language
MIT License
220 stars 134 forks source link

SMPP Server. #21

Closed vagruchi closed 8 years ago

vagruchi commented 8 years ago

This is what i think must be in simple server. But this realization has some problems. For example with close close conn. Need help with it.

fiorix commented 8 years ago

The smpptest package is for testing only, analogous to net/http/httptest. If we are going to have proper server code it has to be in the smpp package.

vagruchi commented 8 years ago

Ok. Also, I can't understand what happenned on tests. Can you explain me for future PullRequests?

fiorix commented 8 years ago

Sure. If you click the Details on the failed test you can scroll down to the ^FAIL message, and above it is the output of the failure. This specific case (https://travis-ci.org/fiorix/go-smpp/builds/128061202#L188) was because of undefined smpptest.NewServer probably because you didn't commit and push that part of your code.