search

fiorix / go-smpp

SMPP 3.4 Protocol for the Go programming language
MIT License
220 stars 134 forks source link

SMPP Server and JSON Marshaling #30

Closed cesarrodrig closed 8 years ago

cesarrodrig commented 8 years ago

Main changes:

gleicon commented 8 years ago

Howdy, good stuff in there ! Can you break this PR by subject ? If you are using an IDE it would be interesting to turn auto commit or bundle the commits. I see refactors like https://github.com/fiorix/go-smpp/pull/30/commits/de6814cb5e78de302fed8468cdc543460ba65a3e that may go back and forth. Maybe git bisect (https://git-scm.com/docs/git-bisect) may help. Thanks a lot !

cesarrodrig commented 8 years ago

Hi, I will attempt to squash commit, and see what I can do to split features but it may be difficult since both occurred at the same time.