search

fiorix / go-smpp

SMPP 3.4 Protocol for the Go programming language
MIT License
220 stars 134 forks source link

Added ISO88595 Code page support #48

Closed wOvAN closed 7 years ago

wOvAN commented 7 years ago

Hi I've added ISO88595 support, test text in txt files in \pdu\pdutext\test_text

wOvAN commented 7 years ago

Made the changes, Except Travis CI

fiorix commented 7 years ago

To fix travis you'll have to update .travis.yml and have only Go 1.7, 1.8 and tip.

fiorix commented 7 years ago

On a side note, I believe golint will complain about your use of underscores in variable names: iso88595UTF8_Bytes -> iso88595UTF8Bytes

wOvAN commented 7 years ago

Underscores fixed, about transmitter_test I'm not ready to troubleshoot this

fiorix commented 7 years ago

Ok. Will keep this open until I find time to fix the tests and then merge your PR.

nezorflame commented 7 years ago

This is fixable by moving to the new context. I guess it's time.

fiorix commented 7 years ago

Merged in #50. There's one follow up though: https://github.com/fiorix/go-smpp/commit/24f8c599fed71be1a83b304ec861d4230fd3df94#diff-6830008c9742aaabdd083a6e0433abffR255