fiote / valheim-bossdirections

A mod that let you make offerings to the fire in exchange of directions for bosses' locations.
0 stars 1 forks source link

File in plugins folder #1

Open GracefulUni opened 8 months ago

GracefulUni commented 8 months ago

Hi, I would highly recommend to not have the json file be located inside the plugins folder, reasons is that whenever you update your mod, anyone who configures the json file will have their file be overwritten due to how r2modman, thunderstore mod managers work. Contents inside plugins folder get basically cleaned up and readded.

Best solution is to make a configuration or a yml file so people can modify without the need of having their needs reset

This is the same issue that EpicLoot does

Good mod though! but would like to see this change if possible

Edit: It be cool too if we can add modded bosses to file too to help find those

fiote commented 8 months ago

I'm thinking about that, yes, thanks for the suggestion tho!

fiote commented 8 months ago

I've moved the pinless value to a configuration file. I'm not sure how to move the actual offerings, because configs don't accept lists, that means it'll stay a json for now - although I'm thinking manually creating a offerings file on the config folder that users can edit (the offerings.json would be read only at the first run to populate it). Not sure yet, tho.

That said, you should be be able to add modded bosses to the offerings.json. My mod is based on location names (like those here: https://valheim-modding.github.io/Jotunn/data/zones/location-list.html). If the modded boss is linked to a specific named location (the mod dev should have more info about that for you), you should be able to add it.

GracefulUni commented 8 months ago

Is it possible to get a changelog for your mod please?

fiote commented 8 months ago

I mean, kinda? You can check the commit list, hah! https://github.com/fiote/valheim-bossdirections/commits/main

fiote commented 8 months ago

Also, there is a little changelog on the main plugin file as well. https://github.com/fiote/valheim-bossdirections/blob/main/Core/Plugin.cs