search

fiplus / fiplus-backend

2 stars 0 forks source link

Match Improvements #192

Closed kim2oden closed 9 years ago

kim2oden commented 9 years ago

Here is my plan for first iteration using social ties we have so far(we only have favourites):

  1. Get the events currently joined by favourited users.
  2. Once we have the list of events where there is atleast one favourited user, go through the event list and see how many favourited users are coming for each.
  3. Sort the event list from events with most favourites coming to events with least favourites coming.
  4. Event list generated by 3 can now be used by other functions for main page results.

What happens in main search for now:

  1. Get events based on interest.
  2. If there's not enough activities to fill up request by interest alone, fill up the activity list from activities with favourited users coming. (Events with more favourited users coming will be filled in first).
  3. If there's still not enough activities after 1 and 2, just fill it up with any activity to fill up requested amount.

Right now, order of importance is. Interest > Social Proximity > Default (where all are pre filtered to be future events).

I am aware that there are console requires atm(Will remove them in last commit).

@seanmikalson @bkhurshi

178

kim2oden commented 9 years ago

Change is underway, don't review this. Things will look a lot different.

kim2oden commented 9 years ago

Update is up that is more in line with Sean's comments. Also I'm aware that there are console logs atm, will remove them when there are no other issues left.

Let me know about potential improvements for this iteration.

@seanmikalson @bkhurshi

kim2oden commented 9 years ago

Heads up, more changes is coming. Also some of the functions in there are not being used at all. Just look at the match request to see which functions are being used. I left the unused functions there just in case I might need them. If they are deemed to be of no use, they'll be removed.

bkhurshi commented 9 years ago

We could test this with the app to see if it looks good.

seanmikalson commented 9 years ago

Some ideas for this change or for future iterations:

bkhurshi commented 9 years ago

@seanmikalson, great ideas. But maybe its too much to do all in one change. Maybe we should add issues for those and work on them after this initial change is in.

kim2oden commented 9 years ago

@seanmikalson : I'll do "Filter out events that the user is joined to" but I'll leave the other suggestions in that list for future change/iterations or once we talked about it together and decide how we want it to work.

I'll also look into the other suggested small suggestions.