search

fiplus / fiplus-backend

2 stars 0 forks source link

Fix cancelled activities being returned in match queries #211

Closed seanmikalson closed 9 years ago

seanmikalson commented 9 years ago

@bkhurshi @kim2oden fixes #208

bkhurshi commented 9 years ago

Can you also prevent cancelled events from being canceled in this change?

bkhurshi commented 9 years ago

Do we have a check somewhere that prevents getting cancelled activities (for the view event screen). The app crashes with Get Activity﹕ {"error":"Not authorized"} when I click a notification for a canceled event. Should be allowed to view cancelled activities from what we are discussing about the flags.

seanmikalson commented 9 years ago

Nope there is not a check throwing an Unauthorized error other than the check to see if you are logged in. Added the check to prevent additional cancels and see ralph's comment about the getDefaultActivities. Will merge soon.

bkhurshi commented 9 years ago

Sure. Then I think that Unauthorized issue might actually be app-side. The notification API call might not be adding the appropriate headers.

bkhurshi commented 9 years ago

:+1:

kim2oden commented 9 years ago

:+1: