search

firasdib / Regex101

This repository is currently only used for issue tracking for www.regex101.com
3.28k stars 199 forks source link

Clicking on a match scrolls and "pops" the matched value in the test string #1005

Closed hobbes3 closed 6 years ago

hobbes3 commented 6 years ago

I often work with test strings that are really looooong (think sometimes over 1 MB of text). When I write a regex and I see a match, I have to carefully scroll manually until I see some highlighted value in the looooong text. Sometimes if I scroll too fast then I miss it.

It would be awesome, if I can simply stay on the "Match Information" side and simply click on the match to see that match value in the test string. Ideally I want to see an animation scroll to the match, then the match to "pop" by doing a little enlarged bounce or something (or possible make it change highlight color briefly).

hobbes3 commented 6 years ago

Is this a bad enhancement request, @firasdib?

firasdib commented 6 years ago

No, this is a great enhancement.

Im just very pressed on time atm. I will try to look at this soon!

Vänliga hälsningar / Best regards,

Firas Dib

On 31 May 2018, at 09:44, Satoshi Kawasaki notifications@github.com wrote:

Is this a bad enhancement request, @firasdib?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Ouims commented 6 years ago

Shit, this is the best feature suggestion i have seen for the website, I have been in that case so many times.

firasdib commented 6 years ago

This is now implemented

TWiStErRob commented 6 years ago

Nice! Not as fluffy as OP wanted, but I think the important thing is the functionality. Wow, it also highlights groups, not just full matches!

firasdib commented 6 years ago

@TWiStErRob I see no point in removing the highlight until the user interacts with the area or they edit their regex (or whatever that might update it). Might be useful to keep it highlighted, and I see no immediate issue with it being so.

Secondly, the animation, is probably just going to be confusing, especially if you have disabled line wrapping and it needs to animate both X and Y axis.