search

firasdib / Regex101

This repository is currently only used for issue tracking for www.regex101.com
3.24k stars 199 forks source link

Update regex requires adding/removing space at end of 'saved name' #1948

Closed apsis0215 closed 1 year ago

apsis0215 commented 1 year ago

Bug Description

Update regex requires adding/removing character in filename

Reproduction steps

login save regexp modify regex update regexp save [greyed out] modify 'personal title' by one character save [now available] save successful

Expected Outcome

Update regexp Save

Browser

Version 107.0.5304.122 (Official Build) (64-bit)

OS

Windows 10 pro 21H2 19044.2251 pack: 120.2212.4180.0

2022-11-30(chrome) t162801 regex101_Date_Time_strings_-_Google_Chrome

firasdib commented 1 year ago

The regex is updated as soon as the modal is shown, i.e., you don't need to do anything else. The save button is means to save the changes you made to your expressions title and similar. Perhaps this is more of a UX issue than a bug. Any suggestions on how to clarify it?

apsis0215 commented 1 year ago

If an icon showed as saved [green checkbox] perhaps? Turns yellow when it is process ing or hasn't been saved (to click on it to save it). Something to indicate the Regex has been saved somewhere.

firasdib commented 1 year ago

Would it be better if there was an artificial delay to show that there has actually been a save?

firasdib commented 1 year ago

I've done a few ux changes to hopefully alleviate the confusion described in this issue.