search

firasdib / Regex101

This repository is currently only used for issue tracking for www.regex101.com
3.2k stars 198 forks source link

Escape ' for Javascript code generator alternative solution #2234

Closed at-ng closed 3 months ago

at-ng commented 4 months ago

Bug Description

Minor bug! Code generator "alternative solution" does not escape '.

Reproduction steps

  1. Select JavaScript flavor
  2. Add ' as regular expression
  3. Click code generator (Javascript)
  4. Note the following line

    // const regex = new RegExp(''', 'gm')

Expected Outcome

The line should be

const regex = new RegExp('\'', 'gm')

as ' needs to be escaped. Or the surrounding quotes could be replaced with something else like `` which is already used below.

Browser

Firefox

OS

Windows

firasdib commented 3 months ago

Thank you, fixed in next release