search

firasdib / regex101-translations

37 stars 27 forks source link

Mostly minor English fixes #11

Closed ghost closed 5 years ago

ghost commented 8 years ago

Fixed some incorrect spelling and wrong words, mostly in the English file.

Zarthus commented 8 years ago

This is definitely going to be a bit of a problem as more language files come up, where you just end up editing the same English string in N different files. A better system for translations wouldn't hurt, although there are also just a lot of inconsistencies in general.

Maybe we should curate the English file fully first? I think this needs some more discussion, eventually.

I fear I did just introduce a conflict by merging existing stale PRs. I can fix those, if you'd like.

firasdib commented 8 years ago

@Zarthus Yes, a good idea would be to fix the english table first. I will see if we can use transifex instead.

firasdib commented 8 years ago

FWIW, we should never edit english.json - this is automatically generated from the source code.

ghost commented 8 years ago

Ah, that might explain why the keys are the same as the actual English translation!