search

firasdib / regex101-translations

37 stars 27 forks source link

Added dutch and french translations #13

Closed nealrobben closed 8 years ago

nealrobben commented 8 years ago

I added some more dutch translations.

Zarthus commented 8 years ago

The dutch looks great to me, I've left one comment even though the translation is not wrong. I'll have someone look at the french part of things as well.

Zarthus commented 8 years ago

hey Neal, we've merged your PR considering we're making the jump to Transifex right now. Our feedback still stands (you just won't be able to fix it via github, but instea via transifex) but for convenience we've merged it anyways so that Transifex has the latest changes.

Thanks for submitting this PR 👍

OnlineCop commented 8 years ago

Can you check the encoding of the french.json file? It's not coming up in UTF-8 for me: Instead, I show it as Western (Mac OS Roman) and several characters appear odd:

nealrobben commented 8 years ago

I just fixed french.json to use UTF-8 and created a new pull request.