search

firasdib / regex101-translations

37 stars 27 forks source link

Tricky order of strings #21

Closed Cosmatevs closed 3 years ago

Cosmatevs commented 5 years ago

Instead of alphabetical order, the strings should be grouped by place where they are on the page. It would give some context and would help to make translations more accurate.

Doqnach commented 5 years ago

many strings can be used in more than one spot, how would you handle that?

firasdib commented 5 years ago

@Doqnach Raises a good point. The strings are unique, which means, the first entry will be included only.

Cosmatevs commented 5 years ago

Some occurrences of duplicates could be skipped if they always appear together or in the same context. The other ones could be commented – I mean: excluded from executing (// comment) – with a note that they have appeared before.

firasdib commented 5 years ago

@Cosmatevs All duplicates must be skipped, or people will translate the same string twice.

You can not have comments inside JSON files.

Cosmatevs commented 5 years ago

So just skip all duplicates and it would still be a better solution than the alphabetical order.

firasdib commented 5 years ago

Yes, I will do so.

@working-name Will a change to the english.json cause issues?

working-name commented 5 years ago

My bad just noticed this. I'm not sure but if it has a seizure I'll just reorder/reimport everything to match the new english, so go for it, whatever helps with translations I'm down.