fire-eggs / CivOne

An open source implementation of Sid Meier's Civilization 1 using C# and .NET.
Creative Commons Zero v1.0 Universal
20 stars 4 forks source link

Coding Standard: game load/save code should not exist in various classes #151

Open fire-eggs opened 2 years ago

fire-eggs commented 2 years ago

Any code related to saving or restoring game state to/from the save file probably should not be in the various implementation classes.

A specific example that came up recently is the "Status" data [with the Settler-specific SetStatus, GetStatus]. These are purely intended for save game state and so should be in Game.LoadSave.cs.

What other properties / methods fit this category?