fire-eggs / CivOne

An open source implementation of Sid Meier's Civilization 1 using C# and .NET.
Creative Commons Zero v1.0 Universal
21 stars 4 forks source link

Game.ActiveUnit.set code looks wrong #184

Open fire-eggs opened 2 years ago

fire-eggs commented 2 years ago

This code:

if (value == null || (value.Busy && !value.Sentry && !value.Fortify))

looks wrong.

The original code:

if (value == null || value.MovesLeft == 0 && value.PartMoves == 0)

Clicking on a unit should "wake it up" and make it active. In the original code, a unit can't be woken up if it has no moves/partmoves left.

The new code I believe will not wake up settlers which are executing orders, which is incorrect.