fire-eggs
commented
2 years ago Many thanks!
Closed EnockNitti closed 2 years ago
fire-eggs
commented
2 years ago Many thanks!
EnockNitti
commented
2 years ago Hi !
Have another matter to discuss. The handling of "cargo" on carriers is different from other sea-units. I found this when I was checking on how the max load on carriers was taken care of. I don't understand the purpose of this difference. Do you have any opinions on this ? There are some bugs here: A bomber flying over a full carrier is losing its movement points. It should not. If a carrier with more than 8 sentried(spelling?) units are moving, the extra units just stay in place still sentried. My problem is: should I just patch it up, or should I rewrite it to a code more like other sea units ?
(Side note: And I think that sea units should not lose their move points when entering a city. Frustrating when a city is just used as canal).
And about End-of-line hell........ I think the comparing of file changes in git is very primitive. I am missing the option to reduce all sequences of blanks to one blank before comparison. This would solve all problems with eol, space/tab and extra spaces at end of text. Anyway: how do you want eol should be handled in this project ?
Side note2: I have spent more time with CIV1 than all other computer games together, and I am still running it now and then. So I am quite familiar with its idiosyncrasies :)
On Sat, 18 Dec 2021 at 19:54, Kevin Routley @.***> wrote:
Many thanks!
— Reply to this email directly, view it on GitHub https://github.com/fire-eggs/CivOne/pull/186#issuecomment-997268890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJL6JPOQB5UIWDJYTCWSDATURTKHPANCNFSM5KIOHLAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
fire-eggs
commented
2 years ago Hi Enock!
So I am quite familiar with its idiosyncrasies
I always play as absolute despotic conqueror so I never reach more advanced technologies such as carriers. Having more users who know about Civ1's "advanced" idiosyncrasies, the better!
RE: carriers I added a new issue. I'm not familiar with the "cargo" code, so can't provide much useful feedback. My approach is usually to patch it up first, then refactor to get "commonality". Any improvements you make in this area will be appreciated!
RE: ports Agreed. I'm pretty sure this was changed for Civ2(?) and onwards. I'd have no problem with making this change as long as it's behind "cheat" control. Added an issue.
Anyway: how do you want eol should be handled in this project ?
You might discuss / coordinate with @iegik - he has proposed(?) some github control over this. And obviously, the pull request from @Andersw88. I'm most concerned about consistency - I don't want to struggle with huge diffs which are only whitespace.
Speaking of consistency, thank you for fixing the brackets in your checkin to 'goto.cs'! I'm ashamed to have missed that from @iegik's pull request ...
I've activated Discussions for the repository, and will add the "eol" topic shortly.
I'll be honest and say I'm more motivated when there is more activity from other folks. Kind of difficult to keep going when it seems like "only me". Many thanks for the ideas and questions! Kevin
EnockNitti
commented
2 years ago Hi ! I have two modes of play "despotic conqueror" or "max science before 0AD using big city". Always as Emperor.
It was a long time since I was actually was using any carriers. Why I bother is because of my work with "smart goto". I have some saved games with carriers I am using for testing. And my work with "smart goto" was from my frustration of units "derailing" and ships going astray. Maybe I will do some more tuning of goto. Now the code is a bit of a compromise due to the fact that movement costs varies for land units (sometimes in a strange way), but not for sea/air units.
I am new to C# and Git. I think this is a fun project to use to learn.
About eol: I can use any method, as long it is consistent. Once I worked a system using CR. Later in a mixed unix-windows environment. You decide what to do. And perhaps decide about using space or tab for indention.
OK: I take a further look at the carrier code.
On Sun, 19 Dec 2021 at 18:58, Kevin Routley @.***> wrote:
Hi Enock!
So I am quite familiar with its idiosyncrasies I always play as absolute despotic conqueror so I never reach more advanced technologies such as carriers. Having more users who know about Civ1's "advanced" idiosyncrasies, the better!
RE: carriers I added a new issue. I'm not familiar with the "cargo" code, so can't provide much useful feedback. My approach is usually to patch it up first, then refactor to get "commonality". Any improvements you make in this area will be appreciated!
RE: ports Agreed. I'm pretty sure this was changed for Civ2(?) and onwards. I'd have no problem with making this change as long as it's behind "cheat" control. Added an issue.
Anyway: how do you want eol should be handled in this project ?
You might discuss / coordinate with @iegik https://github.com/iegik - he has proposed(?) some github control over this. And obviously, the pull request from @Andersw88 https://github.com/Andersw88. I'm most concerned about consistency - I don't want to struggle with huge diffs which are only whitespace.
Speaking of consistency, thank you for fixing the brackets in your checkin to 'goto.cs'! I'm ashamed to have missed that from @iegik https://github.com/iegik's pull request ...
I've activated Discussions for the repository, and will add the "eol" topic shortly.
I'll be honest and say I'm more motivated when there is more activity from other folks. Kind of difficult to keep going when it seems like "only me". Many thanks for the ideas and questions! Kevin
— Reply to this email directly, view it on GitHub https://github.com/fire-eggs/CivOne/pull/186#issuecomment-997434443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJL6JPKSELNOCPZ3CBDCJHLURYMNZANCNFSM5KIOHLAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
…canavas