search

fire-eggs / DarkThumbs

Adds thumbnail preview to Windows Explorer for EPUB, FB2, DJVU and Kindle ebooks; 7Z, CB7, CBZ, CBR, RAR and ZIP archives.
452 stars 23 forks source link

Upgrade RAR support for WinRAR "RAR5" format #78

Closed NeverSm1le closed 7 months ago

NeverSm1le commented 1 year ago

Thumbnails generation works perfectly on png/jpg but not webp or avif contained in archive. Hope you can add support in the next update.

fire-eggs commented 1 year ago

Please see issue #49.

NeverSm1le commented 1 year ago

Thank you for your help but it still doesn't work, guess it's the problem with webp in general.

fire-eggs commented 1 year ago

If you could let me have a copy of the book(s) showing the problems I could dig further.

NeverSm1le commented 1 year ago

Upon further investigation, the same webp files worked in a .zip but not in a .rar. Here's a copy of both files, hope you can shed some more light on this. I used Windows 10, Winrar 6.23 is used to compress both files.

https://drive.google.com/drive/folders/1opXnT51-Z-aCbgiK4Q_VOR4zCmGaaTO1?usp=share_link

fire-eggs commented 1 year ago

Thank you!

fire-eggs commented 1 year ago

I took a quick look at the .RAR file. It looks like you found a limitation of the RAR support in DarkThumbs.

DarkThumbs' RAR support is a little old now and doesn't handle the latest RAR5 format produced by WinRAR 5.0 and later. I wasn't aware of this newer format and so updating the RAR code hasn't been a priority. I'll bump it up on the priority list!

The work-around would be to use the "old" RAR format in WinRAR, or use ZIP.

[ I've just determined that my favorite comic reader doesn't handle that RAR5 archive either! I'll have to let them know! ]

Thanks again!

13xforever commented 7 months ago

New versions of WinRAR dropped support for legacy format, all newly created archives are using the new rar5 format, so it might be a good idea to revisit this issue.

fire-eggs commented 7 months ago

DarkThumbs V1.8 has been updated with the latest WinRAR code to support RAR5.

I also fixed a problem where image formats (such as WEBP) which required a Windows codec would not work with RAR files.