To investigate: other escaped characters in coverfile

fire-eggs / DarkThumbs

Adds thumbnail preview to Windows Explorer for EPUB, FB2, DJVU and Kindle ebooks; 7Z, CB7, CBZ, CBR, RAR and ZIP archives.

451 stars 23 forks source link

To investigate: other escaped characters in coverfile #8

Closed fire-eggs closed 3 years ago

fire-eggs commented 3 years ago

The following code:

coverfile = rootpath + itemTag.substr(posStart, posEnd - posStart);
ReplaceStringInPlace(coverfile, "%20", " ");

is intended to deal with escaped spaces in the cover image filename. What other characters are legal in filenames which need to be escaped for XML?

L0garithmic commented 3 years ago

I don't think there should ever be anything else in the filename for the cover besides a space. However Monday or so when I'm back home. I can look in a ton of my epub files and see if there's any that stick out

Optionally. Ask this in the calibre forum. Those guys are ultra ebook nerds

fire-eggs commented 3 years ago

Found one - '@' is escaped as %40

fire-eggs commented 3 years ago

Replaced the code which looked for only '%20" with a general URL decoder. Will ship in V1.3.