notonyournelly[CodePlex] The code underlying quotExport placesquot in PlacesExport.cs has several issues and could be cleaned up.
It would be more efficient to filter the peopleCollection for living/private once at the beginning, rather than repeat for each sub-task.
The work performed for births, deaths, etc is extremely similar and should be refactored out to a common subroutine.
The work performed for marriages and divorces are extremely similar and should be refactored out to a common subroutine.
Split out the work for places/times/lifespans into separate subroutines. The class/method should be made static.
notonyournelly[CodePlex]
The code underlying quotExport placesquot in PlacesExport.cs has several issues and could be cleaned up.
It would be more efficient to filter the peopleCollection for living/private once at the beginning, rather than repeat for each sub-task. The work performed for births, deaths, etc is extremely similar and should be refactored out to a common subroutine. The work performed for marriages and divorces are extremely similar and should be refactored out to a common subroutine. Split out the work for places/times/lifespans into separate subroutines. The class/method should be made static.