search

fire-eggs / YAIV

"Yet Another Image Viewer"
MIT License
3 stars 0 forks source link

Now failing outside the dev box #122

Closed fire-eggs closed 1 year ago

fire-eggs commented 1 year ago

Been working fine on the dev box.

Built and copied to alternate box. Now refuses to load many files.

Seems OK with animated GIF. Possibly sensitive to the first file in folder being a jpg/png.

fire-eggs commented 1 year ago

Possibly related: while trying various folders, YAIV logged the following:

Load /home/kevin/temp/testImages/カントク Publicity Visual book 電子書籍/2216000.webp

However, that file doesn't exist in that folder. That file is from the previously (successfully) loaded file list.

Is the file scanner thread not properly shutting down / re-initializing / re-syncing when the target folder changes?

fire-eggs commented 1 year ago

Problem identified.

I had introduced an optimization in the file scanner to use openat instead of open. This avoided repetitive string building and was supposedly faster. Unfortunately, in the failure cases, the openat was successful, but the subsequent read failed! With the result that the image format was undetermined and no images were added to the file list.

The directories where openat succeeded were mounts of network folders. Directories when openat failed, as shown in the previous comment, were local.

It was working on the dev box because all target folders were network mounts.