ISSUE-32 Subprocess run error code now not ignored

fireant-bot / fireant

Fireant is a Dependabot-like service (tailored to Apache Ant + Ivy projects) which creates pull requests to keep your dependencies secure and up-to-date.

https://github.com/fireant-bot/fireant

Apache License 2.0

1 stars 1 forks source link

ISSUE-32 Subprocess run error code now not ignored #44

Closed jamie-meyer closed 3 years ago

jamie-meyer commented 3 years ago

Subprocess run had ignored non-zero exit. Now it does not. Linked issue #32

jamie-meyer commented 3 years ago

It's possible that the commands have different locations, not all in /usr/bin/. My ant is in /usr/local/bin/ for example while my git is in /usr/bin/ so I'm not sure what should be done to fix the failing Python check other than to set a rule to ignore it.

lewismc commented 3 years ago

@jamie-meyer you could execute a search similar to which java this would return a path to the executable which you then use in the subprocess call.

lewismc commented 3 years ago

Excellent